Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Icon and Apps Icons #7

Open
OS-the-Person opened this issue Sep 29, 2019 · 4 comments

Comments

@OS-the-Person
Copy link
Owner

commented Sep 29, 2019

Task:
-To add a search icon to the search bar in such a way that it is visible when the search bar is both small and maximized.
-To add an Apps icon to the apps link as a background image.

N//B: all images should be saved in images folder for project neatness.
Icons should be transparent png(s) or SVG(s) and should be as small as possible
i.e. make the icons small but don't get it to appear pixelated.
Happy coding :)

@feliperucunha

This comment has been minimized.

Copy link

commented Sep 30, 2019

I'm working on it

@OS-the-Person

This comment has been minimized.

Copy link
Owner Author

commented Sep 30, 2019

Make sure everything is working fine on your end when you are done.
If you have done your best and it still doesn't appear fine, still commit on a separate branch.
I will give you tips.

@feliperucunha

This comment has been minimized.

Copy link

commented Sep 30, 2019

Hello, thank you for your response. I'm using SVGs as icons and I'm having two issues:
- The APPS icon's link is separate due to (I guess) CSS. It's functional though.
- The SEARCH icon is not going inside the search bar, it's right beside it.

@OS-the-Person

This comment has been minimized.

Copy link
Owner Author

commented Sep 30, 2019

I'm going to admit, this is a pretty tricky task given the code.
TIP:
-To be able to display stuff in the search bar, you have to create a div containing the search bar
If you are still having trouble, I will update the HTML leaving comments on where to place things in
about 15hrs from now.

feliperucunha added a commit to feliperucunha/OS_google_clone that referenced this issue Oct 1, 2019
It's done OS-the-Person#7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.