From 9b5afbb03164257ac2921f8a906d7bc297321ad1 Mon Sep 17 00:00:00 2001 From: jekuaitk Date: Fri, 14 Feb 2025 11:29:32 +0100 Subject: [PATCH 1/4] Update GitHub workflows runner images --- .github/workflows/pr.yaml | 4 ++-- CHANGELOG.md | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 9eadec0..5c494b9 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -136,7 +136,7 @@ jobs: composer code-analysis markdown-coding-standards: - runs-on: ubuntu-20.04 + runs-on: ubuntu-latest name: Markdown coding standards steps: - name: Checkout @@ -155,7 +155,7 @@ jobs: - name: Yarn install uses: actions/setup-node@v2 with: - node-version: '16' + node-version: '22' - run: yarn install - name: coding-standards-check run: yarn coding-standards-check diff --git a/CHANGELOG.md b/CHANGELOG.md index 91a33cd..d55400b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,10 @@ Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] +### Updated + +- Update GitHub workflows runner images + ## [1.1.3] ### Updated From 4ff762d84da7e6ae1b82d23779dc997079d6ae4a Mon Sep 17 00:00:00 2001 From: jekuaitk Date: Fri, 14 Feb 2025 12:17:23 +0100 Subject: [PATCH 2/4] Make drupal-check work --- composer.json | 1 + 1 file changed, 1 insertion(+) diff --git a/composer.json b/composer.json index 85a5725..0362e0d 100644 --- a/composer.json +++ b/composer.json @@ -26,6 +26,7 @@ "drupal/coder": "^8.3", "dealerdirect/phpcodesniffer-composer-installer": "^0.7.1", "mglaman/drupal-check": "^1.4", + "mglaman/phpstan-drupal": "~1.2.0", "phpunit/phpunit": "^9.5" }, "autoload-dev": { From d6bd82548e91afad283ec0f8698cc72e7a52e52a Mon Sep 17 00:00:00 2001 From: jekuaitk Date: Fri, 14 Feb 2025 12:17:33 +0100 Subject: [PATCH 3/4] Apply coding standards --- src/Controller/WebformController.php | 2 +- src/Helper/ImportHelper.php | 2 +- src/Helper/WebformHelper.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Controller/WebformController.php b/src/Controller/WebformController.php index a6c1662..a0b8658 100644 --- a/src/Controller/WebformController.php +++ b/src/Controller/WebformController.php @@ -32,7 +32,7 @@ public function __construct( readonly private RequestStack $requestStack, readonly private ImportHelper $importHelper, readonly private WebformHelper $webformHelper, - readonly private RendererInterface $renderer + readonly private RendererInterface $renderer, ) { } diff --git a/src/Helper/ImportHelper.php b/src/Helper/ImportHelper.php index bed3f94..1b7144e 100644 --- a/src/Helper/ImportHelper.php +++ b/src/Helper/ImportHelper.php @@ -75,7 +75,7 @@ public function __construct( Connection $database, TimeInterface $time, Settings $settings, - CacheBackendInterface $cache + CacheBackendInterface $cache, ) { $this->webformEntityStorage = $entityTypeManager->getStorage('webform'); $this->client = $client; diff --git a/src/Helper/WebformHelper.php b/src/Helper/WebformHelper.php index 58f7184..b66d549 100644 --- a/src/Helper/WebformHelper.php +++ b/src/Helper/WebformHelper.php @@ -47,7 +47,7 @@ final class WebformHelper { public function __construct( EntityTypeManagerInterface $entityTypeManager, ImportHelper $importHelper, - RequestStack $requestStack + RequestStack $requestStack, ) { $this->webformEntityStorage = $entityTypeManager->getStorage('webform'); $this->importHelper = $importHelper; From 31688a3648d3230b778038906ba364dc3077ca79 Mon Sep 17 00:00:00 2001 From: jekuaitk Date: Fri, 14 Feb 2025 12:21:49 +0100 Subject: [PATCH 4/4] Resolve class --- src/Helper/WebformHelper.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Helper/WebformHelper.php b/src/Helper/WebformHelper.php index b66d549..520892e 100644 --- a/src/Helper/WebformHelper.php +++ b/src/Helper/WebformHelper.php @@ -37,7 +37,7 @@ final class WebformHelper { /** * The request stack. * - * @var Symfony\Component\HttpFoundation\RequestStack + * @var \Symfony\Component\HttpFoundation\RequestStack */ private RequestStack $requestStack;