Validate IoT device metadata upon submit #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GufCab
reviewed
Mar 15, 2022
Contributor
GufCab
left a comment
GufCab
left a comment
There was a problem hiding this comment.
Minor changes, can be merged after fixing
|
|
||
| for (const key of Object.keys(json)) { | ||
| if (typeof key !== "string" || key.trim() === "") { | ||
| this.message = `The key whose value is "${json[key]}" must be a valid text value`; |
Contributor
There was a problem hiding this comment.
Use proper translation key (+ translation in frontend)
Contributor
Author
There was a problem hiding this comment.
Agreed. I've done away with hinting at which row has the error. The current setup (i.e. throwing a generic BadRequestException in nest.js) doesn't easily allow additional info to be passed to the frontend. That, or I'm blind.
Contributor
Author
There was a problem hiding this comment.
In case you have a suggestion, I'll leave this open. Otherwise, you can merge this PR
# Conflicts: # package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic validation to IoT device metadata when submitted. It also fixed a TS error which came of one of the dependabots updating the package.lock file.
Supposedly, the mqtt package is now missing a dependency which this PR adds back. Related PR
Related frontend PR