Added "get adr algorithms" endpoint #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you very much for making this PR, @MStenkaer. We have started the process of getting a review, and as of now we'll be able to do it in October or November. |
AramAlsabti
suggested changes
Sep 14, 2022
Contributor
AramAlsabti
left a comment
AramAlsabti
left a comment
There was a problem hiding this comment.
Nicely done. I only have a minor suggestion
AramAlsabti
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added endpoint for retrieving the adr algorithms for the default network server, which uses the endpoint
/api/network-servers/{network_server_id}/adr-algorithmsfrom the ChirpStack network server api.Needed for resolving OS2iot/OS2iot-frontend#103