Added message to prompt when attempting to delete application with ex… #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isting devices. Cleaned code in a few files.
src/assets/i18n/da.json
Outdated
| "CREATE": "Opret applikation", | ||
| "SAVE": "Gem applikation", | ||
| "DELETE": "Slet applikation", | ||
| "DELETE-HAS-DEVICES-PROMPT": "Der er knyttet IoT-enheder til denne applikation. Disse vil også blive slettet. Slet alligevel?", |
Contributor
There was a problem hiding this comment.
Missing english translation. Indentation should be fixed as well
Contributor
Author
There was a problem hiding this comment.
Indentation fixed. English translation not added - if we want to support english we need to fill out the entire file in one go.
| getMinimal(): Observable<OrganisationGetMinimalResponse> { | ||
| return this.restService.get(this.URLMINIMAL, {}).pipe(shareReplay(1)); | ||
| const test = this.restService.get(this.URLMINIMAL, {}).pipe(shareReplay(1)); | ||
| console.log('Minimal Organization Response', test); |
Contributor
There was a problem hiding this comment.
I guess this was not meant to be included?
MadsSvejstrup
approved these changes
Nov 4, 2021
ramogens-OS2
deleted the
issue/47_delete-devices-when-deleting-application
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…isting devices. Cleaned code in a few files.
The user is now notified when attempting to delete an application that has devices. Combined with PR123 in the backend repo, this fixes #47