Added functionality and prompt message when attempting to delete app with sigfox #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gFox device * Added message and functionality to check and to prompt when attempting to delete application with SigFox device
MadsSvejstrup
suggested changes
Nov 18, 2021
src/app/applications/applications-list/applications-table/applications-table.component.ts
Outdated
Show resolved
Hide resolved
src/app/applications/applications-list/applications-table/applications-table.component.ts
Outdated
Show resolved
Hide resolved
…ich i missed before.
MadsSvejstrup
suggested changes
Nov 19, 2021
Contributor
MadsSvejstrup
left a comment
MadsSvejstrup
left a comment
There was a problem hiding this comment.
I thinks there's a bit too much duplicate logic regarding the delete dialog in application-table.component and application-detail.component.
I think we could avoid this by refactoring it into a showApplicationDialog() method in DeleteDialogService
src/app/applications/application-detail/application-detail.component.ts
Outdated
Show resolved
Hide resolved
MadsSvejstrup
approved these changes
Nov 22, 2021
Contributor
MadsSvejstrup
left a comment
MadsSvejstrup
left a comment
There was a problem hiding this comment.
Looking good now! :)
augusthjerrild
deleted the
issue/47_prompt-user-when-deleting-sigfox-application
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added message to prompt and functionality when attempting to delete application with SigFox device