Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC Desktop support for singularity #388

Open
johrstrom opened this issue Jan 23, 2020 · 2 comments
Open

BC Desktop support for singularity #388

johrstrom opened this issue Jan 23, 2020 · 2 comments
Assignees
Milestone

Comments

@johrstrom
Copy link
Contributor

@johrstrom johrstrom commented Jan 23, 2020

This discourse topic came in where someone wanted to run a singularity image instead of say, xfce, in the bc_desktop application.

This ticket is to support that use case.

I think the easiest way would be to add a singularity.sh to apps/bc_desktop/template/desktops and some way to specify the image and the command in the form.yml and these variables in turn show up in the shell script.

The topic creator wanted a way to override script.sh.erb (and instead use a sh file in /etc/ood/config). Of course we can discuss that option here, but I think that's a much larger change for the actual feature requested.

@ericfranz ericfranz added this to the Backlog milestone Jan 30, 2020
@novosirj

This comment has been minimized.

Copy link

@novosirj novosirj commented Feb 4, 2020

I think my request is ultimately more useful to more people, as it seems to me there might be a lot more possibilities for differences you'd want to have in the desktop launch script, and it makes some of that stuff a little more modular/extensible, but I'm no expert on the existing codebase and I may not understand the ramifications.

That said, if it's a lot more work and this other method can be used to satisfy this request at least in the meantime, I think that's a win all around. My primary motivation was to have something that I don't have to maintain myself when the changes are so minimal/could be handled by overlaying a couple of the files if that were supported.

Is there something I can do to help somehow, including passing on how we do this today?

@johrstrom

This comment has been minimized.

Copy link
Contributor Author

@johrstrom johrstrom commented Feb 4, 2020

Yea my thinking with the first approach was to have environment variables for image and entrypoint like BC_DESKTOP_SING_IMG and BC_DESKTOP_SING_ENTRY so folks could point to say /opt/ood/config/bc_desktop/singularity/{cool_img.sif,cool_entry.sh} but something that could pull initially from shub:// so it worked out of the box.

But I agree with your desire for it to be modifiable/extendible and that the first option would have to those properties.

And yea, I think any input you want to give us is great! Especially in requirements or what your current solution looks like.

@msquee msquee self-assigned this Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.