Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify columns returned in activejobs #394

Open
johrstrom opened this issue Feb 10, 2020 · 1 comment
Open

Specify columns returned in activejobs #394

johrstrom opened this issue Feb 10, 2020 · 1 comment

Comments

@johrstrom
Copy link
Contributor

@johrstrom johrstrom commented Feb 10, 2020

A user on discourse wants to add a column to active jobs.

This ticket is to enable such a feature. It looks like it's a view only work as the data exists, we've just hard coded what the columns are.

I would think the interface for such a feature would be and environment variable listing out all the columns requested or maybe an initializer overriding the some class doing this work?

The environment variable may default to something like this:
ACTIVE_JOB_VIEW_COLUMNS=ID,NAME,USER,ACCOUNT,TIME_USED,QUEUE,STATUS,CLUSTER

@ericfranz

This comment has been minimized.

Copy link
Contributor

@ericfranz ericfranz commented Feb 11, 2020

A little technical design here would help the discussion. What parts of the code would change to accommodate this? The table in Active Jobs is filtering Info objects, so the candidate columns would need to map directly to either a method on Info or a key on the Info#native. The problem of course with native is it is adapter specific so if you add a column that uses this.

Also what would happen if an invalid field was added? Perhaps some type of warning that an invalid field is configured, explaining why it is empty? Or maybe the column exists but it appears with read in the header with a (!) with an explanation below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.