Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic logrotation of PUN logs #53

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@treydock
Copy link
Contributor

commented Aug 8, 2019

No description provided.

@johrstrom

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

Why not add our weekly and rotate 52 directives? I get that this is a basic config, but I feel like those are super liberal but still put some limits in place.

@MorganRodgers
Copy link
Contributor

left a comment

This works for me, but I agree with Jeff that adding the weekly and rotate 52 directives feel like they'd be reasonable additions.

@treydock

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

It's not really appropriate to assume how often people want logs rotated and how many to keep. That is typically defined globally in /etc/logrotate.conf. The stock logrotate configs for /etc/logrotate.d that come from other software stacks do not assume a rotation period or retention so I opted to follow that pattern.

@MorganRodgers

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

If there are other knobs for log rotation such that users do not have to mess with RPM installed files, then I think that this is good to go as is. @johrstrom thoughts? Or shall we merge?

@johrstrom

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

I'm fine with this.

@MorganRodgers MorganRodgers merged commit d457d57 into master Aug 14, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@MorganRodgers MorganRodgers deleted the logrotate branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.