IPS & ood-portal-generator: Change whitelist to allowlist

[matthu017]

Deals with ips and ood_portal_generator

[johrstrom]

I fixed the merge conflict and rebased to master. I think we're good with this, there's a test case testing the current config and the previous config against the same file, so it's in good shape.

[johrstrom]

Can I get a second pair of eyes on this @treydock?

I added test cases that utilize fixture files rather than stubbing context. I kinda like testing those boundaries, rather than stubbing classes. In fact, I'd kinda like to refactor this a little towards that.

[johrstrom]

Do you have any thoughts on the testing strategy I'd like to move towards? Input fixture files are small enough and won't need to change alot - but output fixture files would need changing across potentially all of them. That's kind of the situation we're in now, but I feel like this library's purpose is to write a file given an input file - so let's test those boundaries.

[treydock]

I think it makes to stub files and test whole files since that's how the application is operating, it works off of files and writes out whole files. The huge benefit to validating entire files is to ensure we know 100% how certain changes affect the entire templates.