Flip defaults #48
Merged
Flip defaults #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
force-pushed
the
flip-defaults
branch
from
053d819
to
fb72e7a
Compare
guimaluf
approved these changes
Feb 7, 2020
Flipping these defaults are more inline with what the more common case would be. Defaults should align with what people do by default, which I think should be installing from the rpm and using the ood_portal_generator.
johrstrom
force-pushed
the
flip-defaults
branch
from
89cee9f
to
197e463
Compare
|
This has sat around for long enough, I think we're good to pull in now. |
|
@johrstrom is this expected to work out of the box on Ubuntu? We had a user report that setting |
|
It should work, though I can open a separate ticket to investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we march to a 1.0 release in Galaxy, I feel like now is the time to solidify these entries as the defaults.
This was originally developed for non-RPM based systems, but I feel like that's the corner case, and indeed, automation targeting RPM based systems is the more common case and defaults should reflect that.
Using the ood-portal-generator also gets flipped to be default. We can keep the template, and even later allow users to specify their own, but this should likely be the default as it probably gives the best "works out of the box" experience.