Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VNC setting controls to noVNC launcher #476

Merged
merged 10 commits into from Jun 13, 2019

Conversation

Projects
None yet
2 participants
@MorganRodgers
Copy link
Contributor

commented Jun 5, 2019

No description provided.

samirmansour and others added some commits May 28, 2019

Merge quality-settings and master and fix issues
Merging master was necessary to fix issues related to translations.

- Resolve merge conflict w/ master
- Use bootstrap_form
- Change text entries to min/maxed number_field
- Remove unnecessary whitespace changes in app.js

@MorganRodgers MorganRodgers requested a review from ericfranz Jun 5, 2019

@MorganRodgers

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

Replaces #474.

@MorganRodgers

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

@ericfranz I like where this has ended up. Shall we aim to include this in 1.6?

@MorganRodgers MorganRodgers merged commit 3d84721 into master Jun 13, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@MorganRodgers MorganRodgers deleted the quality-setting-update branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.