Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select ssh host #201

Merged
merged 4 commits into from Jun 13, 2019

Conversation

Projects
None yet
2 participants
@MorganRodgers
Copy link
Contributor

commented Jun 7, 2019

Edited

If the environment variable OOD_SSH_HOSTS is set then a dropdown button will appear in place of the regular single click button. OOD_SSH_HOSTS completely overrides OOD_SHELL. OOD_SSH_HOSTS is expected to be a comma delimited list of colon delimited pairs. The first half of the pair needs to be the SSH host and the second should be a human-friendly label for the cluster. The URL to the Shell app may be customized by setting OOD_SHELL_URL (e.g. OOD_SHELL_URL=/pun/sys/alternative-shell-app/ssh).

For example at OSC we would use OOD_SSH_HOSTS=owens.osc.edu:Owens,ruby.osc.edu:Ruby,pitzer.osc.edu:Pitzer.

Note that there is no support at this time for filtering clusters, which is not ideal in cases where not all users have access to a given cluster.

Other decisions of note:

  • The rendering engine has been partially changed to Handlebars instead of Rendy to support conditionals and loops
  • Bootstrap CSS and JS have been included in the project files, and were previously served via a CDN

MorganRodgers added some commits Jun 7, 2019

Adds the ability to SSH to multiple hosts from the file explorer
If the environment variable `OOD_SSH_HOSTS` is set then a dropdown button will appear in place of the regular single click button. `OOD_SSH_HOSTS` is expected to be a comma delimited list of colon delimited pairs. The first half of the pair needs to be the URL to connect to the shell for and must contain the full connection URL (/pun/sys/shell/ssh/...), and the second should be a human-friendly label for the cluster.

For example at OSC we would use '/pun/sys/shell/ssh/owens.osc.edu:Owens,/pun/sys/shell/ssh/ruby.osc.edu:Ruby,/pun/sys/shell/ssh/pitzer.osc.edu:Pitzer'.

Note that there is no support at this time for filtering clusters, which is not ideal in cases where not all users have access to a given cluster.

Other decisions of note:

- The rendering engine has been partially changed to Handlebars instead of Rendy to support conditionals and loops
- Bootstrap CSS and JS have been included with the JS coming from the same CDN that we are using for jquery

@MorganRodgers MorganRodgers requested a review from ericfranz Jun 7, 2019

@ericfranz

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

I think the design should change so OOD_SSH_HOSTS changes from:

/pun/sys/shell/ssh/owens.osc.edu:Owens,/pun/sys/shell/ssh/ruby.osc.edu:Ruby,/pun/sys/shell/ssh/pitzer.osc.edu:Pitzer

to

owens.osc.edu:Owens,ruby.osc.edu:Ruby,pitzer.osc.edu:Pitzer
@@ -19,6 +20,7 @@

<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/jstree/3.2.1/themes/default/style.min.css" />
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/1.12.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/3.4.1/js/bootstrap.min.js" integrity="sha256-nuL8/2cJ5NDSSwnKD8VqreErSWHtnEP9E7AySL+1ev4=" crossorigin="anonymous"></script>

This comment has been minimized.

Copy link
@ericfranz

ericfranz Jun 11, 2019

Contributor

We should change the app so that these assets are served by the app instead of pulled from a CDN.

This comment has been minimized.

Copy link
@MorganRodgers

MorganRodgers Jun 12, 2019

Author Contributor

This and the the note about OOD_SSH_HOSTS has been addressed.

MorganRodgers added some commits Jun 12, 2019

Moved the Shell app URL specification into the environment variable O…
…OD_SHELL_URL

OOD_SHELL_URL is the same env variable that ood-appkit uses.

@MorganRodgers MorganRodgers requested a review from ericfranz Jun 12, 2019

@MorganRodgers MorganRodgers merged commit f0a3c36 into master Jun 13, 2019

@MorganRodgers MorganRodgers deleted the select-ssh-host branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.