New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Edit files" button should say "View files" if the template is read-only #279

Open
ericfranz opened this Issue Jan 8, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@ericfranz
Copy link
Contributor

ericfranz commented Jan 8, 2019

See screenshot. The selected template is read only. However it says "Edit Files". This should instead say "View Files". Note that the Files app is not smart enough yet to disable the edit button if it is a read-only file.

screen 2019-01-08 at 2 55 55 pm

  • An expensive way to determine this would be to stat the files in the template directory.
  • A cheaper way would be to simply have the button say "View Files" if it is a "System Template".

@ericfranz ericfranz added this to the OOD1.5 milestone Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment