Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative no-copy workflow that does not add a new menu item #302

Closed
wants to merge 5 commits into from

Conversation

@MorganRodgers
Copy link
Contributor

commented Jun 5, 2019

Alternative to #301.

  • Ask if the workflow dir should not be copied, avoids needing to have a default checked checkbox which bootstrap_form_for does not support
  • Add Workflow#should_not_copy member so that bootstrap_form_for doesn't complain
  • Add flow control to skip copy safe check if we are not copying
Alternative no-copy workflow that does not add a new menu item
Ask if the workflow dir should not be copied, avoids needing to have a default checked checkbox which bootstrap_form_for does not support
Add should_not_copy member to the class so that bootstrap_form_for doesn't complain
Add flow control to skip copy safe check if we are not copying

@MorganRodgers MorganRodgers requested a review from ericfranz Jun 12, 2019

@MorganRodgers

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

When a user deletes a job controlled by this app the directory is removed. This could lead to confusing behavior if a job is removed that contains another.

@ericfranz is this still something that we want to move ahead with?

@MorganRodgers

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

This is work is incomplete and should not be merged. There is no way for a user to remove a job without deleting its source directory, and that is a problem because what if a user creates a 'job' in their home directory? A complete solution would need to handle:

  • Refusing to delete a job created at the root of a user's home directory
  • Handling creating/deleting a job in a directory that already contains a job
  • Handling creating/deleting a job in a directory that already is a job

There may be a use case in allowing multiple jobs to be created in the same directory (multiple programs, same data), but deletion of one should not automatically assume that both jobs, and thus their files, should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.