New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reviewed geoext QuickStart #526
Conversation
@flicstar - changes look good. A few comments:
|
Thanks @geographika I update the heading markup and also made them title case. I think my preference is for sentence case but sometimes it's hard for me to know which things are proper nouns and so require capitalization. Also the 'What Next' at the end does look better as title case and consistency is important. |
@flicstar - see flicstar#1 |
doc/quickstart/geoext_quickstart.rst
Outdated
ensure you have permissions to save the file open Leafpad from the command line with elevated permissions using the | ||
In this step we will set-up an empty HTML page which will contain the application. We'll use the text editor Leafpad installed on OSGeoLive to create a new HTML file at ``/var/www/html/geoext/demo.html`` | ||
|
||
#. Open Leafpad from the command line with elevated permissions (so you can save the file) using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geographika Any idea why these "numbers" are displaying as hash symbols rather than numbers? Argh! I can see your tip about indenting the codeblocks has worked in the later sections, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flicstar - see flicstar#2 - the text also has to be aligned with the block.
Fix linebreaks for numbering in GeoExt
http://irclogs.geoapt.com/osgeolive/%23osgeolive.2019-11-26.log 20:14:30 sethg: "mapserver, mapcache, geoext can all be considered approved" |
Reviewed as part of the QuickStart project during Google Season of Docs 2019. The aim is consistency across all OSGeoLive QuickStarts. Also see PR 498 #498
The document is structured well and only requires minor changes.
@geographika Please action comments and suggestions you agree with, and ignore those you don't.
Partner trac ticket link: https://trac.osgeo.org/osgeolive/ticket/2195
See this page for reference: https://trac.osgeo.org/osgeolive/wiki/How%20to%20document%20the%20quickstart%20file