Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1992 fix sf shared folder #231

Merged
merged 6 commits into from Aug 14, 2018

Conversation

Projects
None yet
2 participants
@kalxas

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

We have to test this, I am not sure if systemd is fully functional in chroot

@kalxas kalxas self-assigned this Aug 13, 2018

@Bakaniko

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2018

We will see next build. Thanks

@kalxas

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

check groups for live user in latest build:
screenshot_20180813_224634

@Bakaniko

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2018

vboxsf group is missing. So it means it didn't work properly.

can you try this please :

sudo systemctl start manage_user_groups

then

sudo systemctl status manage_user_groups

Just to see if the service is correctly configured

Thanks

@kalxas

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

from build log:

Running in chroot, ignoring request: daemon-reload
@kalxas

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

screenshot_20180814_010931

@kalxas

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

rest of the error message:
screenshot_20180814_011452

@Bakaniko

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2018

Thanks @kalxas, I'll look at it today with the latest build

Fix previous commit
* Add absolute path to /usr/sbin/adduser
* fix missing service name to enable (so the service is launch at startup)
* starts the service in chroot
* remove fuse from groups as it is not exiting (removed from the ISO ?) and generating an error

@kalxas, I tested it manually in last build osgeolive-nightly-build200-amd64-34cddf6-master.iso
I still needed to logout/login to get it working, but it should be ok with the live ISO
@Bakaniko

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2018

@kalxas I fixed the path for adduser + some other changes. I also tested it so it should be working now.

Sorry for the delay

@kalxas

This comment has been minimized.

Copy link
Member

commented Aug 14, 2018

Thanks @Bakaniko
I will build and test this today.

@kalxas

This comment has been minimized.

Copy link
Member

commented Aug 14, 2018

It now works but I feel it makes the boot slower. Perhaps we should not add all those groups, since each user gets membership by default.

@Bakaniko

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2018

I think it should be triggered once, during the build.
So it ensure user is part of the groups, then it starts normally.

If it doesn't work, I can reduce so it only trigger adduser for vboxsf at each startup.

I'll make a commit in that sens.

Add user only to vboxsf group, disable automatic check at startup
It should be only triggered during the build
@kalxas

This comment has been minimized.

Copy link
Member

commented Aug 14, 2018

triggering once will not work, since the user gets deleted, this is why rc.local was used in the first place

@@ -67,7 +71,7 @@ systemctl daemon-reload
systemctl start manage_user_groups.service

## Enable manage_user_groups service at startup
systemctl enable manage_user_groups.service
#systemctl enable manage_user_groups.service

This comment has been minimized.

Copy link
@kalxas

kalxas Aug 14, 2018

Member

just enable this back please and I will test

@kalxas

This comment has been minimized.

Copy link
Member

commented Aug 14, 2018

thanks

@kalxas kalxas merged commit 812befa into OSGeo:master Aug 14, 2018

@Bakaniko

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2018

Thanks to you, it is something I wanted to do 2 years ago. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.