From ab2d175bf1674e3472576250281e7fdb68f09198 Mon Sep 17 00:00:00 2001
From: Thomas Knudsen <busstoptaktik@users.noreply.github.com>
Date: Mon, 12 Feb 2018 22:45:20 +0100
Subject: [PATCH] Rename gie_failing to work around MS wildcard bug (#799)

For reasons unknown to anyone but the geniuses from Redmond: In
MSWindows, the wildcard pattern "*.gie" expands to all files having
an extension *starting* with ".gie".

In other words "dir *.gie" will list files with extension ".gie"
*and* with extension ".gie_failing".

This means that running "gie test\gigs\*.gie" will run all gigs
tests, even the ones known to fail.

So rather than getting a quick check for regressions, one gets
a lot of noise and no easy way to be sure whether any regressions
have appeared.

To work around this oddity, we rename all files ending in
".gie_failing" to end in ".gie.failing" - and while at it,
adding all the non-failing gigs tests to the AppVeyor test suite.

This extends the regression test suite, run at the end of each
AppVeyor integration, to over 2500 individual tests.

Test coverage, however, is still hovering just below 75%, so
there's still plenty of room and reason for additional tests.
---
 appveyor.yml                                                 | 2 +-
 test/gigs/{5101.4-jhs.gie_failing => 5101.4-jhs.gie.failing} | 0
 test/gigs/{5102.2.gie_failing => 5102.2.gie.failing}         | 0
 test/gigs/{5104.gie_failing => 5104.gie.failing}             | 0
 test/gigs/{5105.1.gie_failing => 5105.1.gie.failing}         | 0
 test/gigs/{5108.gie_failing => 5108.gie.failing}             | 0
 test/gigs/{5110.gie_failing => 5110.gie.failing}             | 0
 test/gigs/{5111.2.gie_failing => 5111.2.gie.failing}         | 0
 test/gigs/{5203.1.gie_failing => 5203.1.gie.failing}         | 0
 test/gigs/{5204.1.gie_failing => 5204.1.gie.failing}         | 0
 test/gigs/{5205.1.gie_failing => 5205.1.gie.failing}         | 0
 test/gigs/{5206.gie_failing => 5206.gie.failing}             | 0
 test/gigs/{5207.1.gie_failing => 5207.1.gie.failing}         | 0
 test/gigs/{5207.2.gie_failing => 5207.2.gie.failing}         | 0
 14 files changed, 1 insertion(+), 1 deletion(-)
 rename test/gigs/{5101.4-jhs.gie_failing => 5101.4-jhs.gie.failing} (100%)
 rename test/gigs/{5102.2.gie_failing => 5102.2.gie.failing} (100%)
 rename test/gigs/{5104.gie_failing => 5104.gie.failing} (100%)
 rename test/gigs/{5105.1.gie_failing => 5105.1.gie.failing} (100%)
 rename test/gigs/{5108.gie_failing => 5108.gie.failing} (100%)
 rename test/gigs/{5110.gie_failing => 5110.gie.failing} (100%)
 rename test/gigs/{5111.2.gie_failing => 5111.2.gie.failing} (100%)
 rename test/gigs/{5203.1.gie_failing => 5203.1.gie.failing} (100%)
 rename test/gigs/{5204.1.gie_failing => 5204.1.gie.failing} (100%)
 rename test/gigs/{5205.1.gie_failing => 5205.1.gie.failing} (100%)
 rename test/gigs/{5206.gie_failing => 5206.gie.failing} (100%)
 rename test/gigs/{5207.1.gie_failing => 5207.1.gie.failing} (100%)
 rename test/gigs/{5207.2.gie_failing => 5207.2.gie.failing} (100%)

diff --git a/appveyor.yml b/appveyor.yml
index 52993558a5..11f16b5df8 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -62,7 +62,7 @@ test_script:
   - dir ..\test\gie
   - echo "Contents of PROJ_LIB " %PROJ_LIB%
   - dir %PROJ_LIB%
-  - gie.exe ..\test\gie\*.gie
+  - gie.exe ..\test\gie\*.gie ..\test\gigs\*.gie
 
 deploy: off
 
diff --git a/test/gigs/5101.4-jhs.gie_failing b/test/gigs/5101.4-jhs.gie.failing
similarity index 100%
rename from test/gigs/5101.4-jhs.gie_failing
rename to test/gigs/5101.4-jhs.gie.failing
diff --git a/test/gigs/5102.2.gie_failing b/test/gigs/5102.2.gie.failing
similarity index 100%
rename from test/gigs/5102.2.gie_failing
rename to test/gigs/5102.2.gie.failing
diff --git a/test/gigs/5104.gie_failing b/test/gigs/5104.gie.failing
similarity index 100%
rename from test/gigs/5104.gie_failing
rename to test/gigs/5104.gie.failing
diff --git a/test/gigs/5105.1.gie_failing b/test/gigs/5105.1.gie.failing
similarity index 100%
rename from test/gigs/5105.1.gie_failing
rename to test/gigs/5105.1.gie.failing
diff --git a/test/gigs/5108.gie_failing b/test/gigs/5108.gie.failing
similarity index 100%
rename from test/gigs/5108.gie_failing
rename to test/gigs/5108.gie.failing
diff --git a/test/gigs/5110.gie_failing b/test/gigs/5110.gie.failing
similarity index 100%
rename from test/gigs/5110.gie_failing
rename to test/gigs/5110.gie.failing
diff --git a/test/gigs/5111.2.gie_failing b/test/gigs/5111.2.gie.failing
similarity index 100%
rename from test/gigs/5111.2.gie_failing
rename to test/gigs/5111.2.gie.failing
diff --git a/test/gigs/5203.1.gie_failing b/test/gigs/5203.1.gie.failing
similarity index 100%
rename from test/gigs/5203.1.gie_failing
rename to test/gigs/5203.1.gie.failing
diff --git a/test/gigs/5204.1.gie_failing b/test/gigs/5204.1.gie.failing
similarity index 100%
rename from test/gigs/5204.1.gie_failing
rename to test/gigs/5204.1.gie.failing
diff --git a/test/gigs/5205.1.gie_failing b/test/gigs/5205.1.gie.failing
similarity index 100%
rename from test/gigs/5205.1.gie_failing
rename to test/gigs/5205.1.gie.failing
diff --git a/test/gigs/5206.gie_failing b/test/gigs/5206.gie.failing
similarity index 100%
rename from test/gigs/5206.gie_failing
rename to test/gigs/5206.gie.failing
diff --git a/test/gigs/5207.1.gie_failing b/test/gigs/5207.1.gie.failing
similarity index 100%
rename from test/gigs/5207.1.gie_failing
rename to test/gigs/5207.1.gie.failing
diff --git a/test/gigs/5207.2.gie_failing b/test/gigs/5207.2.gie.failing
similarity index 100%
rename from test/gigs/5207.2.gie_failing
rename to test/gigs/5207.2.gie.failing