Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inverse lagrange projection #1058

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Conversation

kbevers
Copy link
Member

@kbevers kbevers commented Jun 25, 2018

Courtesy of Michael Stumpf mi12st34@gmail.com

@kbevers
Copy link
Member Author

kbevers commented Jun 25, 2018

The failing scenarios should also be tested. I will add those later today or tomorrow when I have time.

src/PJ_lagrng.c Outdated
x2 = xy.x * xy.x;
y2p = 2. + xy.y;
y2m = 2. - xy.y;
if (fabs(c = y2p * y2m - x2) < TOL) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't do assignments in ifs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, I'll fix that right away

@kbevers kbevers force-pushed the inverse-lagrange branch 3 times, most recently from 96c2a77 to ab79504 Compare June 26, 2018 10:15
Courtesy of Michael Stumpf <mi12st34@gmail.com>
@kbevers kbevers merged commit 3eb56db into OSGeo:master Jun 26, 2018
@kbevers kbevers deleted the inverse-lagrange branch July 9, 2018 08:46
@kbevers kbevers added this to the 5.2.0 milestone Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants