Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tobler-Mercator projection #1153

Merged
merged 1 commit into from Oct 15, 2018
Merged

Add Tobler-Mercator projection #1153

merged 1 commit into from Oct 15, 2018

Conversation

@sphynx
Copy link
Contributor

@sphynx sphynx commented Oct 14, 2018

Resolves #584

test/gie/builtins.gie Show resolved Hide resolved
Copy link
Member

@kbevers kbevers left a comment

Thanks for adding this. I've requested a few changes in the docs otherwise this looks good.

docs/source/operations/projections/tobmerc.rst Outdated Show resolved Hide resolved
docs/source/operations/projections/tobmerc.rst Outdated Show resolved Hide resolved
docs/source/operations/projections/tobmerc.rst Outdated Show resolved Hide resolved
@kbevers
Copy link
Member

@kbevers kbevers commented Oct 15, 2018

Thanks. I missed it before, we also need to add the version of inclusion: .. versionadded:: 6.0.0. Like this:

********************************************************************************
Tobler-Mercator
********************************************************************************

.. versionadded:: 6.0.0

Equal area cylindrical projection with the same latitudinal spacing as
Mercator projection.

@kbevers
Copy link
Member

@kbevers kbevers commented Oct 15, 2018

I am happy with this now. This should only be a 1 commit change. Do you want to squash the existing commits yourself (for full credit) or should just squash-merge it right away?

@sphynx sphynx force-pushed the tobler-mercator branch from c75afd8 to f2b8a5e Oct 15, 2018
@sphynx
Copy link
Contributor Author

@sphynx sphynx commented Oct 15, 2018

I am happy with this now. This should only be a 1 commit change. Do you want to squash the existing commits yourself (for full credit) or should just squash-merge it right away?

Thank you for the review! Squashed.

@kbevers kbevers merged commit 117a3f4 into OSGeo:master Oct 15, 2018
2 checks passed
@kbevers kbevers added this to the 6.0.0 milestone Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants