Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove proj_def.dat (#201) #1210

Merged
merged 3 commits into from
Dec 27, 2018
Merged

Conversation

rouault
Copy link
Member

@rouault rouault commented Dec 27, 2018

This also fixes a regression recently added in PROJ master now that cs2cs is using underneath the new ISO19111 code to generate pipeline, which doesn't emit +no_defs, and thus cause issues with CRS using LCC_1SP projections that erroneously use the lat_2=45 default of proj_def.dat

operation proj=merc
accept 0 0
expect 0 0
expect failure errno major_axis_not_given
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because we now don't have a default ellipsoid?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that would leave many projections default-less with regards to ellipsoids. It seems to me that +proj=merc not working without adding +ellps=... is a step in the wrong direction. I think setting ellipsoid parameters for GRS80 when initialising a PJ would be a sane default. If +ellps=bessel (or whatever) is set it will obviously be overridden.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, default to ellps=GRS80 per 6bb14fa

@kbevers
Copy link
Member

kbevers commented Dec 27, 2018

Looks good to me!

@kbevers kbevers merged commit 1230114 into OSGeo:master Dec 27, 2018
@kbevers kbevers added this to the 6.0.0 milestone Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants