Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gie return non-zero exit code when file can't be opened #1312

Merged
merged 1 commit into from Mar 6, 2019

Conversation

@kbevers
Copy link
Member

@kbevers kbevers commented Mar 6, 2019

Simple fix to #1311

@kbevers
Copy link
Member Author

@kbevers kbevers commented Mar 6, 2019

Downside to this fix is that it still runs the tests for files that can be found:

$ ./bin/gie ../repo/test/gigs/5101.4-jhs-etmerc.gie unknown
-------------------------------------------------------------------------------
Reading file '../repo/test/gigs/5101.4-jhs-etmerc.gie'
-------------------------------------------------------------------------------
total: 69 tests succeeded,  0 tests skipped,  0 tests failed.
-------------------------------------------------------------------------------
Cannot open spec'd input file 'unknown' - bye!

Should the input files be tested for existence before running the tests? It goes a bit against the architecture of the application (one pass does everything) but it can prevent that says that everything is okay before giving a error that seems insignificant at a glance.

Loading

@kbevers
Copy link
Member Author

@kbevers kbevers commented Mar 6, 2019

Should the input files be tested for existence before running the tests?

I decided to do this. Seems better to me.

Loading

@kbevers kbevers merged commit 94c923a into OSGeo:master Mar 6, 2019
2 checks passed
Loading
@kbevers kbevers added this to the 6.0.1 milestone Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant