Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: automatically enable system error messages #1336

Merged
merged 1 commit into from Mar 22, 2019
Merged

Conversation

@cjmayo
Copy link
Contributor

@cjmayo cjmayo commented Mar 20, 2019

Define HAVE_STRERROR from configure.

Before:

$ cs2cs +proj=latlong +to +proj=latlong dummy
<cs2cs>:
Sys errno: 2: <system mess. texts unavail.>
dummy

After:

$ cs2cs +proj=latlong +to +proj=latlong dummy
<cs2cs>:
Sys errno: 2: No such file or directory
dummy

Tested against 6.0.0, and 5.2.0.

@kbevers
Copy link
Member

@kbevers kbevers commented Mar 21, 2019

Nice catch. Please apply the same fix to the CMake setup as well, so that build with either system works the same.

Loading

Define HAVE_STRERROR during configuration.

Before:
$ cs2cs +proj=latlong +to +proj=latlong dummy
<cs2cs>:
Sys errno: 2: <system mess. texts unavail.>
dummy

After:
$ cs2cs +proj=latlong +to +proj=latlong dummy
<cs2cs>:
Sys errno: 2: No such file or directory
dummy
@cjmayo cjmayo changed the title Automatically enable system error messages using Autotools Build: automatically enable system error messages Mar 21, 2019
@cjmayo
Copy link
Contributor Author

@cjmayo cjmayo commented Mar 21, 2019

Added CMake support.

Loading

@kbevers kbevers added this to the 6.0.1 milestone Mar 22, 2019
@kbevers kbevers merged commit f8ba1db into OSGeo:master Mar 22, 2019
3 checks passed
Loading
@backporting
Copy link

@backporting backporting bot commented Mar 22, 2019

The backport to 6.0 failed:

Commits ["ddd333e6bd6f5e033a2b829067910165e64eb0b9"] could not be cherry-picked on top of 6.0

Loading

@kbevers
Copy link
Member

@kbevers kbevers commented Mar 22, 2019

Added CMake support.

Thank you very much!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants