Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cs2cs support 4D coordinates. #1355

Merged
merged 1 commit into from Mar 24, 2019
Merged

Make cs2cs support 4D coordinates. #1355

merged 1 commit into from Mar 24, 2019

Conversation

@kbevers
Copy link
Member

@kbevers kbevers commented Mar 24, 2019

This is a bit of a hack, 4D coordinates will be written to STDOUT
but the output format speficied with -f is not respected for the
t component, rather it is forward verbatim from the input.

Fixes #1354

Copy link
Member

@rouault rouault left a comment

Perhaps a test in test/cli/testvarious

Loading

src/apps/cs2cs.cpp Outdated Show resolved Hide resolved
Loading
This is a bit of a hack, 4D coordinates *will* be written to STDOUT
but the output format speficied with -f is not respected for the
t component, rather it is forward verbatim from the input.

Fixes OSGeo#1354
@kbevers
Copy link
Member Author

@kbevers kbevers commented Mar 24, 2019

Perhaps a test in test/cli/testvarious

Done.

Loading

@kbevers
Copy link
Member Author

@kbevers kbevers commented Mar 24, 2019

To be honest, this is not an ideal fix but it will work for the foreseeable future. The proper fix is to rewrite cs2cs more or less completely and have it be 4D by default. A good candidate for a breaking change introduced with PROJ 7.

Loading

@kbevers kbevers added this to the 6.0.1 milestone Mar 24, 2019
@kbevers kbevers merged commit 4f78797 into OSGeo:master Mar 24, 2019
3 checks passed
Loading
kbevers added a commit that referenced this issue Mar 24, 2019
Backport #1355 on 6.0: Make cs2cs support 4D coordinates.
@kbevers kbevers deleted the cs2cs-4d branch Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants