Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set discard superseded method to api #1534

Merged
merged 7 commits into from Jul 19, 2019

Conversation

@matherno
Copy link
Contributor

commented Jun 26, 2019

Added proj_operation_factory_context_set_discard_superseded() function to API.
Also made it so that FilterResults::removeUninterestingOps() is not called if not discarding superseded operations.

@kbevers

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

Please update scripts/reference_exported_symbols.txt:

Difference(s) found in exported symbols. If intended, refresh scripts/reference_exported_symbols.txt with 'scripts/dump_exported_symbols.sh src/.libs/libproj.so > scripts/reference_exported_symbols.txt'

@kbevers kbevers requested a review from rouault Jun 26, 2019

@kbevers

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

Closes #1519

Matt Littlemore added 2 commits Jun 26, 2019
@@ -947,6 +947,7 @@ proj_operation_factory_context_set_desired_accuracy
proj_operation_factory_context_set_grid_availability_use
proj_operation_factory_context_set_spatial_criterion
proj_operation_factory_context_set_use_proj_alternative_grid_names
proj_operation_factory_context_set_discard_superseded

This comment has been minimized.

Copy link
@rouault

rouault Jun 29, 2019

Member

symbols should be sorted. so move this line just after proj_operation_factory_context_set_desired_accuracy

@rouault

This comment has been minimized.

Copy link
Member

commented Jun 29, 2019

Could you also please add a test in test/unit/test_c_api.cpp ?

@rouault

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

@matherno ping ^

Matt Littlemore added 2 commits Jul 4, 2019
Matt Littlemore
Matt Littlemore
Add tests for new API function
Two tests, for each state set by proj_operation_factory_context_set_discard_superseded

@kbevers kbevers merged commit 0fc4242 into OSGeo:master Jul 19, 2019

4 checks passed

FreeBSD Task Summary
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.01%) to 85.929%
Details

@kbevers kbevers added this to the 6.2.0 milestone Jul 19, 2019

@kbevers

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

@matherno Thanks for your contribution. Sorry for not getting round to merging this sooner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.