Add set discard superseded method to api #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update
|
|
Closes #1519 |
rouault
reviewed
Jun 29, 2019
| @@ -947,6 +947,7 @@ proj_operation_factory_context_set_desired_accuracy | |||
| proj_operation_factory_context_set_grid_availability_use | |||
| proj_operation_factory_context_set_spatial_criterion | |||
| proj_operation_factory_context_set_use_proj_alternative_grid_names | |||
| proj_operation_factory_context_set_discard_superseded | |||
There was a problem hiding this comment.
symbols should be sorted. so move this line just after proj_operation_factory_context_set_desired_accuracy
|
Could you also please add a test in test/unit/test_c_api.cpp ? |
|
@matherno ping ^ |
… place in symbols file
Two tests, for each state set by proj_operation_factory_context_set_discard_superseded
|
@matherno Thanks for your contribution. Sorry for not getting round to merging this sooner! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added proj_operation_factory_context_set_discard_superseded() function to API.
Also made it so that FilterResults::removeUninterestingOps() is not called if not discarding superseded operations.