Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C API: add proj_context_set_autoclose_database() to automatically close database (fixes #1565) #1566

Merged

Conversation

@rouault
Copy link
Member

commented Aug 19, 2019

No description provided.

@rouault rouault force-pushed the rouault:add_proj_context_set_autoclose_database branch 2 times, most recently from dfd0ff3 to 1e9fe45 Aug 19, 2019

@snowman2

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

Thanks for this addition! This works well for the tests I ran on my machine. No issues found. Apparently the global context idea I had does not work on Windows for some reason (issue referenced in this PR), but this should fix the pyproj issues after removing the global context.

@snowman2

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

Is this going to make it into 6.2.0?

@rouault

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

Maybe @kbevers want to have a look at that ?

@kbevers

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

If everyone is happy with the PR as it is now, sure, let's get in 6.2.0 :-)

@kbevers kbevers added this to the 6.2.0 milestone Aug 21, 2019

@rouault rouault merged commit b7f829c into OSGeo:master Aug 22, 2019

4 checks passed

FreeBSD Task Summary
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage decreased (-0.02%) to 85.868%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.