Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid_alternatives.sql: Add DLX_ETRS89_geo.gsb and D73_ETRS89_geo.gsb … #1571

Merged
merged 3 commits into from
Sep 1, 2019
Merged

grid_alternatives.sql: Add DLX_ETRS89_geo.gsb and D73_ETRS89_geo.gsb … #1571

merged 3 commits into from
Sep 1, 2019

Conversation

PedroVenancio
Copy link
Contributor

…grids in grid_alternatives (added in proj-datumgrid-europe package per OSGeo/proj-datumgrid#54)

…grids in grid_alternatives (added in proj-datumgrid-europe package per OSGeo/proj-datumgrid#54)
@PedroVenancio
Copy link
Contributor Author

Travis and Cirrus checks are failing with

Error: near line 34951: insert on grid_alternatives violates constraint: original_grid_name must be referenced in grid_transformation.grid_name

but both original_grid_name I'm inserting are present in grid_transformation.grid_name:

https://github.com/OSGeo/PROJ/blob/master/data/sql/grid_transformation.sql#L193

https://github.com/OSGeo/PROJ/blob/master/data/sql/grid_transformation.sql#L194

Any hint about what can be causing the fails?

@rouault
Copy link
Member

rouault commented Aug 31, 2019

Any hint about what can be causing the fails?

Yes, subtle difference in the capitalization : DLx_ETRS89_geo.gsb (in grid_transformation.sql) vs DLX_ETRS89_geo.gsb in grid_alternatives.sql. But the better would perhaps be that you fix OSGeo/proj-datumgrid#54 to use the exact case used by EPSG ?

@PedroVenancio
Copy link
Contributor Author

Hi @rouault

Thank you very much! I think it is ready now. And also OSGeo/proj-datumgrid#54

@kbevers kbevers merged commit 8417e70 into OSGeo:master Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants