Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stick with proj.lib on windows #1581

Merged
merged 1 commit into from Sep 5, 2019
Merged

stick with proj.lib on windows #1581

merged 1 commit into from Sep 5, 2019

Conversation

jef-n
Copy link
Contributor

@jef-n jef-n commented Sep 3, 2019

I'd suggest to keep using proj.lib as library name - even if the dll is called differently. Had to adapt the lib name twice in the last few days for QGIS and GDAL…

@rouault
Copy link
Member

@rouault rouault commented Sep 3, 2019

There's an issue with proj.lib coming from the library, and proj.lib coming from the src/apps/proj.cpp utility. This shows up only in the x86 builds which use -DBUILD_LIBPROJ_SHARED=OFF
Probably something should be tweaked in src/bin_proj.cmake to make it use a non conflicting name

@jef-n
Copy link
Contributor Author

@jef-n jef-n commented Sep 3, 2019

There's an issue with proj.lib coming from the library, and proj.lib coming from the src/apps/proj.cpp utility. This shows up only in the x86 builds which use -DBUILD_LIBPROJ_SHARED=OFF
Probably something should be tweaked in src/bin_proj.cmake to make it use a non conflicting name

on it

@kbevers
Copy link
Member

@kbevers kbevers commented Sep 4, 2019

Resolves #1479

@kbevers kbevers added this to the 7.0.0 milestone Sep 5, 2019
@kbevers kbevers merged commit 06578ae into OSGeo:master Sep 5, 2019
4 checks passed
@jef-n jef-n deleted the win-no-abi-lib branch Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants