Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proj_create_crs_to_crs_from_pj(): make the PJ* arguments const PJ* #1583

Merged

Conversation

@rouault
Copy link
Member

rouault commented Sep 4, 2019

This will make the life of C++ users using the C API slightly easier.
There's no ABI or API backward compatibility issue in doing that change as
constness of arguments is not retained in the C ABI, and any non-const
object passed as argument is implicitly converted as a const object if
that is what is mentionned in the argument list.

@rouault rouault added the backport 6.2 label Sep 4, 2019
@kbevers kbevers added this to the 6.2.1 milestone Sep 4, 2019
@kbevers

This comment has been minimized.

Copy link
Member

kbevers commented Sep 4, 2019

/bin/bash: q : commande introuvable

is this a copy'n'paste gone wrong?

This will make the life of C++ users using the C API slightly easier.
There's no ABI or API backward compatibility issue in doing that change as
constness of arguments is not retained in the C ABI, and any non-const
object passed as argument is implicitly converted as a const object if
that is what is mentionned in the argument list.
@rouault rouault force-pushed the rouault:constify_proj_create_crs_to_crs_from_pj branch from be842cd to d7d8f45 Sep 4, 2019
@rouault

This comment has been minimized.

Copy link
Member Author

rouault commented Sep 4, 2019

is this a copy'n'paste gone wrong?

yep, just fixed in commit message and PR text

@rouault rouault merged commit ab1fb55 into OSGeo:master Sep 5, 2019
4 checks passed
4 checks passed
FreeBSD Task Summary
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 85.904%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.