Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: add SANITIZE_CTX for coordoperation is_instantiable and has_ballpark_transformation #1590

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@snowman2
Copy link
Contributor

snowman2 commented Sep 6, 2019

This one was causing core dumping for me - had me digging through my code to find it and eventually I pinpointed the issue to these functions.

…park_transformation
@kbevers

This comment has been minimized.

Copy link
Member

kbevers commented Sep 6, 2019

Can you explain the circumstances of the core dump?

@rouault

This comment has been minimized.

Copy link
Member

rouault commented Sep 6, 2019

Can you explain the circumstances of the core dump?

Pretty simple I think. If you passed ctx == NULL to this function, it failed to use the default global context, and thus a null pointer dereferece would occur.

@snowman2 So you use an implicit context in some places of your code ?

@rouault rouault added the backport 6.2 label Sep 6, 2019
@rouault rouault merged commit b7ed294 into OSGeo:master Sep 6, 2019
4 checks passed
4 checks passed
FreeBSD Task Summary
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.0007%) to 85.9%
Details
@kbevers

This comment has been minimized.

Copy link
Member

kbevers commented Sep 6, 2019

Pretty simple I think. If you passed ctx == NULL to this function, it failed to use the default global context, and thus a null pointer dereferece would occur.

Thanks. I am just trying to get enough info in here so I don't have to spend too much time writing release notes in two months time. This helps a lot!

@kbevers kbevers added this to the 6.2.1 milestone Sep 6, 2019
@snowman2

This comment has been minimized.

Copy link
Contributor Author

snowman2 commented Sep 8, 2019

So you use an implicit context in some places of your code ?

Not currently. Just testing it out for a potential solution to #1591 when I ran into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.