Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors running gie-based tests in Debug mode on Windows #1688

Merged
merged 1 commit into from Nov 3, 2019

Conversation

@apacker1
Copy link
Contributor

apacker1 commented Oct 23, 2019

In Debug mode on Windows, the gie executable is actually built as "gie_d", so all the gie tests fail because they can't find the executable.

@kbevers

This comment has been minimized.

Copy link
Member

kbevers commented Oct 23, 2019

Is gie the only app that get's the _d prefix or would the same fix also be applicable to proj, cs2cs, cct, projinfo and geod? It's been a while since I build on Windows but I do seem to remember seeing this before.

@mwtoews

This comment has been minimized.

Copy link
Member

mwtoews commented Oct 23, 2019

See https://github.com/OSGeo/PROJ/blob/master/CMakeLists.txt#L169-L173 which does set(CMAKE_DEBUG_POSTFIX _d) for MSVC multi-config builds.

@apacker1

This comment has been minimized.

Copy link
Contributor Author

apacker1 commented Oct 23, 2019

@kbevers

Is gie the only app that get's the _d prefix or would the same fix also be applicable to proj, cs2cs, cct, projinfo and geod? It's been a while since I build on Windows but I do seem to remember seeing this before.

Yes, all those executables are built with "_d" suffix. None of those seem to cause any failures when I run ctest though.

@kbevers

This comment has been minimized.

Copy link
Member

kbevers commented Oct 23, 2019

Yes, all those executables are built with "_d" suffix. None of those seem to cause any failures when I run ctest though.

Still kinda annoying, I think.

@mwtoews is there a good reason to keep the _d suffixes?

@apacker1

This comment has been minimized.

Copy link
Contributor Author

apacker1 commented Oct 23, 2019

The dll also has the suffix, ie, "proj_6_2_d.dll"

@mwtoews

This comment has been minimized.

Copy link
Member

mwtoews commented Oct 23, 2019

I was investigating this issue sometime last year (sorry, I didn't post this as an issue earlier), but I can't recall if I came to any conclusions on the matter except that there was an inconstancy that needed fixing...

@rouault rouault merged commit 90c1166 into OSGeo:master Nov 3, 2019
4 checks passed
4 checks passed
FreeBSD Task Summary
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 85.636%
Details
@kbevers kbevers added this to the 6.3.0 milestone Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.