Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix proj_assign_context()/pj_set_ctx() with pipelines and alternative coord operations #1726
Conversation
… coord operations Fixes OSGeo/gdal#1989 pj_set_ctx() only changes the context to the main object. It should also recurse down to the steps of the pipeline and the alternative coordinate operations hold in alternativeCoordinateOperations In the GDAL use case with multithreaded reprojection, and objects being transferred between thread, this would cause a failed coordinate transformation to affect an unrelated transformation of another thread...
This comment has been minimized.
This comment has been minimized.
|
@rouault the next version is 6.3.0 so it is strictly not necessary to backport to the 6.2 branch. No harm in doing it, just want to make sure that we are on the same page regarding the release schedule. As for the fix, it seems like the right way to deal with this problem. |
This comment has been minimized.
This comment has been minimized.
Agreed. Just in case people would pull from the 6.2 branch for such narrow scope fixes |
rouault
added a commit
to rouault/gdal
that referenced
this pull request
Nov 12, 2019
…hread which created it (fixes OSGeo#1989). This workarounds a PROJ bug also fixed per OSGeo/PROJ#1726
rouault
added a commit
to rouault/gdal
that referenced
this pull request
Nov 12, 2019
…hread which created it (fixes OSGeo#1989). This workarounds a PROJ bug also fixed per OSGeo/PROJ#1726
rouault
added a commit
to OSGeo/gdal
that referenced
this pull request
Nov 12, 2019
…hread which created it (fixes #1989). This workarounds a PROJ bug also fixed per OSGeo/PROJ#1726
rouault
added a commit
to OSGeo/gdal
that referenced
this pull request
Nov 12, 2019
…hread which created it (fixes #1989). This workarounds a PROJ bug also fixed per OSGeo/PROJ#1726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rouault commentedNov 12, 2019
Fixes OSGeo/gdal#1989
pj_set_ctx() only changes the context to the main object. It should also
recurse down to the steps of the pipeline and the alternative coordinate
operations hold in alternativeCoordinateOperations
In the GDAL use case with multithreaded reprojection, and objects being transferred
between thread, this would cause a failed coordinate transformation to affect
an unrelated transformation of another thread...