Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proj_assign_context()/pj_set_ctx() with pipelines and alternative coord operations #1726

Merged
merged 1 commit into from Nov 12, 2019

Conversation

@rouault
Copy link
Member

rouault commented Nov 12, 2019

Fixes OSGeo/gdal#1989

pj_set_ctx() only changes the context to the main object. It should also
recurse down to the steps of the pipeline and the alternative coordinate
operations hold in alternativeCoordinateOperations

In the GDAL use case with multithreaded reprojection, and objects being transferred
between thread, this would cause a failed coordinate transformation to affect
an unrelated transformation of another thread...

… coord operations

Fixes OSGeo/gdal#1989

pj_set_ctx() only changes the context to the main object. It should also
recurse down to the steps of the pipeline and the alternative coordinate
operations hold in alternativeCoordinateOperations

In the GDAL use case with multithreaded reprojection, and objects being transferred
between thread, this would cause a failed coordinate transformation to affect
an unrelated transformation of another thread...
@kbevers kbevers added this to the 6.3.0 milestone Nov 12, 2019
@kbevers

This comment has been minimized.

Copy link
Member

kbevers commented Nov 12, 2019

@rouault the next version is 6.3.0 so it is strictly not necessary to backport to the 6.2 branch. No harm in doing it, just want to make sure that we are on the same page regarding the release schedule.

As for the fix, it seems like the right way to deal with this problem.

@rouault

This comment has been minimized.

Copy link
Member Author

rouault commented Nov 12, 2019

No harm in doing it, just want to make sure that we are on the same page regarding the release schedule.

Agreed. Just in case people would pull from the 6.2 branch for such narrow scope fixes

rouault added a commit to rouault/gdal that referenced this pull request Nov 12, 2019
…hread which created it (fixes OSGeo#1989). This workarounds a PROJ bug also fixed per OSGeo/PROJ#1726
@rouault rouault merged commit 899b7ef into OSGeo:master Nov 12, 2019
4 checks passed
4 checks passed
FreeBSD Task Summary
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage decreased (-0.01%) to 85.797%
Details
rouault added a commit to rouault/gdal that referenced this pull request Nov 12, 2019
…hread which created it (fixes OSGeo#1989). This workarounds a PROJ bug also fixed per OSGeo/PROJ#1726
rouault added a commit to OSGeo/gdal that referenced this pull request Nov 12, 2019
…hread which created it (fixes #1989). This workarounds a PROJ bug also fixed per OSGeo/PROJ#1726
rouault added a commit to OSGeo/gdal that referenced this pull request Nov 12, 2019
…hread which created it (fixes #1989). This workarounds a PROJ bug also fixed per OSGeo/PROJ#1726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.