Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Only export symbols if building DLL #1773

Merged
merged 1 commit into from Dec 11, 2019

Conversation

@orudge
Copy link
Contributor

orudge commented Dec 4, 2019

If you build Proj as a static library (e.g., using vcpkg), then subsequently build a DLL linking to the Proj libraries, all the Proj symbols get exported in your DLL.

@rouault

This comment has been minimized.

Copy link
Member

rouault commented Dec 11, 2019

ping @cffk : could you review the change in geodesic.h ?

@cffk

This comment has been minimized.

Copy link
Contributor

cffk commented Dec 11, 2019

ping @cffk : could you review the change in geodesic.h ?

This looks fine...

@rouault rouault merged commit 5b4e60f into OSGeo:master Dec 11, 2019
4 checks passed
4 checks passed
FreeBSD Task Summary
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 85.961%
Details
@cffk

This comment has been minimized.

Copy link
Contributor

cffk commented Dec 12, 2019

Sorry to second guess myself. But I don't see where geodesic.h has a
dllimport option when used by a program that links to proj. Also
instead of the cmake files for the utilities setting
PROJ_MSVC_DLL_IMPORT=1, wouldn't it make more sense for the library to
make this an INTERFACE definition?

I'm not familiar enough with the intricacies of Windows dlls to know how
this might need to be fixed without actually trying it -- and
unfortunately, I'm off on vacation soon and so won't be able to look
into this until the beginning of Jan.

@kbevers kbevers added this to the 6.3.0 milestone Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.