Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more ESRI projection method mappings #2020

Merged
merged 4 commits into from Mar 5, 2020

Conversation

nyalldawson
Copy link
Contributor

Adds

  • Mercator_Variant_A
  • Mercator_Variant_C
  • Transverse_Cylindrical_Equal_Area


# Hammer_Aitoff: possibly hammer?
# Hammer_Ellipsoidal: possibly hammer?
# Eckert_Greifendorff: +proj=hammer +W=0.25 +m=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Eckert_Greifendorff: +proj=hammer +W=0.25 +m=1
# Eckert_Greifendorff: +proj=hammer +W=0.25 +M=1

@rouault
Copy link
Member

rouault commented Mar 4, 2020

For the sake of being good open source citizens (and have an up-to-date reference), provided that Esri/projection-engine-db-doc#17 is merged, we should probably contribute updates to https://github.com/Esri/projection-engine-db-doc/blob/master/other/proj4-esri.txt, especially in the "PE projections not supported by PROJ4 " to make it smaller :-) Good candidates that we have already mapped are: Behrmann, Plate_Carree, Equidistant_Cylindrical_Ellipsoidal, Mercator_Auxiliary_Sphere

@nyalldawson
Copy link
Contributor Author

There's quite a few "*" (only in libproject flag) which can be removed too...

@nyalldawson
Copy link
Contributor Author

nyalldawson commented Mar 4, 2020

(besides, I'd find it kind of amusing if ESRI repos had me as a contributor 🙃)

@rouault
Copy link
Member

rouault commented Mar 5, 2020

I'd find it kind of amusing of ESRI repos had me as a contributor

ahah, be reassured, you're not alone: https://github.com/Esri/lerc/commits?author=rouault :-)

@rouault rouault added this to the 7.1.0 milestone Mar 5, 2020
@rouault rouault merged commit b8db250 into OSGeo:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants