Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adams Square II: map ESRI WKT to PROJ string, and implement iterative inverse method #2157

merged 2 commits into from Apr 16, 2020


Copy link

@rouault rouault commented Apr 15, 2020

  • Tests added
  • Added clear title that can be used to generate release notes
  • Fully documented, including updating docs/source/*.rst for new API

Copy link
Member Author

rouault commented Apr 15, 2020

Inverse projection is needed for gdalwarp for example:

$ gdalwarp -r cubic ../autotest/gdrivers/data/small_world.tif /tmp/out.png -t_srs "+proj=adams_ws2" -overwrite
Creating output file that is 447P x 447L.
0...10...20... 30...40...50../tmp.60...70...80../out.90...100 - done.


Copy link

Nice -- I was just building master to see if I could map these new ones! Did you look into mapping Peirce_Quincuncial yet?

Copy link

@kbevers kbevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I like the generic approach to the inverse adams_ws2, good thinking!

src/iso19111/coordinateoperation.cpp Outdated Show resolved Hide resolved
src/projections/adams.cpp Show resolved Hide resolved
test/gie/more_builtins.gie Outdated Show resolved Hide resolved
src/iso19111/coordinateoperation.cpp Show resolved Hide resolved
@rouault rouault force-pushed the map_esri_54098 branch 2 times, most recently from d54d408 to f40c41c Compare April 16, 2020 10:13
Copy link
Member Author

rouault commented Apr 16, 2020

Did you look into mapping Peirce_Quincuncial yet?

no. Not sure I'll do

Copy link

Hooray! This is awesome @rouault!

@kbevers: I see from your comments that you consider making this a generic fill-in for one-way projections, which is even more awesome. If you should succeed, consider making the core derivative computations part of derivs.cpp/pj_derivs().

Also, the material covered in factors.cpp may give some insight in how perversely deform the projected space may be locally.

@rouault rouault merged commit ff8258b into OSGeo:master Apr 16, 2020
@kbevers kbevers added this to the 7.1.0 milestone Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants