Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gie: implement a strict mode with <gie-strict> </gie-strict> (fixes #2158) #2168

Merged
merged 1 commit into from Apr 22, 2020

Conversation

rouault
Copy link
Member

@rouault rouault commented Apr 19, 2020

In that mode:

  • All non-comment/decoration lines must start with a valid tag
  • Commands split on several lines should be terminated with " \"

@busstoptaktik @kbevers Before I make the effort of converting all gie files in test/gie/ with those rules, I want to have your blessing

@rouault rouault changed the title [WIP] gie: implement a strict_mode command [WIP] gie: implement a strict_mode command (fixes #2158) Apr 19, 2020
@busstoptaktik
Copy link
Member

I have no strong feelings around this, although I probably would have preferred the syntax I proposed in #2158: <gie-strict> ... </gie-strict>, which more clearly indicates that it is the entire environment that is to be considered strict.

If I understand your proposed syntax correctly, the strictness may shift half way through the input file (in which case, I believe there should also be a way to switch back to lax mode again).

Anyway - most important to me is to keep the original syntax as the default, as it really is quite useful in its own right, as demonstrated in the PROJ teaching material, I linked to over in #2158.

@rouault
Copy link
Member Author

rouault commented Apr 20, 2020

<gie-strict> ... </gie-strict>

ah sorry I missed that part, and was actually thinking about something similar. Just pushed this

@rouault rouault changed the title [WIP] gie: implement a strict_mode command (fixes #2158) [WIP] gie: implement a strict mode with <gie-strict> </gie-strict> (fixes #2158) Apr 20, 2020
@busstoptaktik
Copy link
Member

ah sorry I missed that part, and was actually thinking about something similar. Just pushed this

Groovy :-)

…SGeo#2158)

In that mode:
* All non-comment/decoration lines must start with a valid tag
* Commands split on several lines should be terminated with " \"
@rouault rouault changed the title [WIP] gie: implement a strict mode with <gie-strict> </gie-strict> (fixes #2158) gie: implement a strict mode with <gie-strict> </gie-strict> (fixes #2158) Apr 21, 2020
@rouault
Copy link
Member Author

rouault commented Apr 21, 2020

All .gie files converted and documentation added in gie.rst. There were a few instances of misspelled expect in builtins.gie

@rouault rouault merged commit 94aa1fc into OSGeo:master Apr 22, 2020
2 checks passed
@kbevers kbevers added this to the 7.1.0 milestone Apr 22, 2020
@rouault
Copy link
Member Author

rouault commented Apr 22, 2020

Just got feedback from @ccrook that he also got hit by expect/except misspelling, so I see a great future for <gie-strict> :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants