Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a +proj=defmodel transformation for multi-component time-based deformation models #2206

Merged
merged 5 commits into from May 17, 2020

Conversation

rouault
Copy link
Member

@rouault rouault commented May 4, 2020

Fixes #1001

The implementation of the transformation mostly resides in the defmodel.hpp header, that is completely PROJ agnostic. This offers the advantage of potentially reusing it for other implementations, and more practically for us, to be able to unit test the building blocks of the transformation that are normally not accessible through the PROJ API. The defmodel.cpp file contains the PROJ specific glue, and implements a few utility methods left unimplemented by the header to read a value in a grid, or perform cartesian<-->geographic conversions.

CC @ccrook who has tested this on the LINZ NZGD2000 deformation model along the development and contributed a few fixes and tests

@rouault rouault force-pushed the deformation_model_for_merge branch 2 times, most recently from 9790a5a to afc669d Compare May 5, 2020
hobu
hobu approved these changes May 12, 2020
src/apps/gie.cpp Outdated Show resolved Hide resolved
src/grids.cpp Show resolved Hide resolved
src/grids.cpp Show resolved Hide resolved
src/grids.cpp Show resolved Hide resolved
src/transformations/defmodel.cpp Show resolved Hide resolved
src/transformations/defmodel.hpp Outdated Show resolved Hide resolved
src/transformations/defmodel.hpp Outdated Show resolved Hide resolved
src/transformations/defmodel.hpp Outdated Show resolved Hide resolved
src/transformations/defmodel.hpp Outdated Show resolved Hide resolved
src/transformations/defmodel.hpp Outdated Show resolved Hide resolved
@rouault
Copy link
Member Author

rouault commented May 12, 2020

Thanks @hobu for the review!

@rouault
Copy link
Member Author

rouault commented May 15, 2020

@kbevers Will you want to do a review on this before I merge ?

@kbevers
Copy link
Member

kbevers commented May 15, 2020

@kbevers Will you want to do a review on this before I merge ?

Yes, please! Sorry for not getting round to it earlier. I've been hella busy the last couple of weeks. I'll try to give it a closer look this weekend.

@rouault
Copy link
Member Author

rouault commented May 15, 2020

Yes, please!

No, problem. Take your time

@rouault rouault force-pushed the deformation_model_for_merge branch from 1b83bb6 to 95e8777 Compare May 16, 2020
Copy link
Member

@kbevers kbevers left a comment

I think this looks very good. I haven't looked super detailed at the code since there's quite a lot of it and my memory of the initial proposal of the deformation model "master file" concept by Chris is good enough for a detailed review. The docs and the examples are rather clear to me and I have not reason to not want to include this PR as is. Good effort!

@rouault rouault merged commit 0403980 into OSGeo:master May 17, 2020
4 checks passed
@ccrook
Copy link
Contributor

ccrook commented May 17, 2020

Thankyou Even, Kristian, and Howard for your contributions to the development of this format specification and Even for the excellent implementation. This is a huge benefit to the New Zealand user community. It means we will be able to move many of our tools to use the PROJ library rather than our own custom software which is great for its long term sustainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for deformation models
4 participants