Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Added temporal, engineering, and parametric datum PJ_TYPE enumerations #2274

Merged
merged 2 commits into from Jul 6, 2020

Conversation

snowman2
Copy link
Contributor

@snowman2 snowman2 changed the title ENH: Added temporal, engineering, and parametric PJ_TYPE enumerations ENH: Added temporal, engineering, and parametric datum PJ_TYPE enumerations Jun 27, 2020
@snowman2
Copy link
Contributor Author

@rouault there is the generic DATUM type. Is there a datum type that isn't covered by this that might pop up?

@snowman2
Copy link
Contributor Author

Any chance of adding this in 7.1?

@kbevers
Copy link
Member

kbevers commented Jun 27, 2020

Any chance of adding this in 7.1?

Not unless there's an RC3 - this PR in itself is not enough to trigger that.

src/proj.h Outdated Show resolved Hide resolved
@snowman2
Copy link
Contributor Author

Not unless there's an RC3 - this PR in itself is not enough to trigger that.

From the perspective of pyproj, it is definitely worth it. 7.1 is the minimum version for the next release. It is a change that will address some current bugs.🤞

@snowman2
Copy link
Contributor Author

snowman2 commented Jun 27, 2020

It is a change that will address some current bugs.

I guess we could export each object to PROJ JSON and check the type there if this isn't added in 7.1 ... not quite as nice of a solution, but it works.

@rouault
Copy link
Member

rouault commented Jun 27, 2020

@kbevers Is this material for 7.1.1 backport ? asking since it extends the API

@kbevers
Copy link
Member

kbevers commented Jul 5, 2020

asking since it extends the API

Then no. A very similar situation is adressed in this SO post: https://stackoverflow.com/questions/27300561/does-adding-enumerators-into-enum-break-abi/

@rouault rouault added this to the 7.2.0 milestone Jul 6, 2020
@rouault rouault merged commit 7cfde8d into OSGeo:master Jul 6, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic Temporal Datum Support (c-api)
3 participants