Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone projCppContext context when copying projCtx_t #2324

Merged
merged 6 commits into from Aug 19, 2020

Conversation

snowman2
Copy link
Contributor

  • Added clear title that can be used to generate release notes

Reasoning:

I made some changes assuming the database path would be copied from the default context. After core dumps, I determined this was not the case. I believe copying the cpp_context will enable this. Thoughts?

Copy link
Member

@rouault rouault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if those new code paths are exercised by the existing test suite. If not, that would be welcome

include/proj/internal/io_internal.hpp Outdated Show resolved Hide resolved
src/iso19111/c_api.cpp Outdated Show resolved Hide resolved
snowman2 and others added 2 commits August 16, 2020 14:24
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
@snowman2
Copy link
Contributor Author

I'm not sure if those new code paths are exercised by the existing test suite. If not, that would be welcome

Sounds like a good idea. I will take a look at it later.

test/unit/proj_context_test.cpp Outdated Show resolved Hide resolved
test/unit/test_c_api.cpp Outdated Show resolved Hide resolved
@rouault rouault added this to the 7.2.0 milestone Aug 19, 2020
@rouault rouault merged commit 8471302 into OSGeo:master Aug 19, 2020
2 checks passed
@snowman2 snowman2 deleted the clone_cpp_context branch August 19, 2020 13:04
@snowman2
Copy link
Contributor Author

Thanks for reviewing @rouault 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants