Clone projCppContext context when copying projCtx_t #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
reviewed
Aug 16, 2020
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
Sounds like a good idea. I will take a look at it later. |
snowman2
force-pushed
the
clone_cpp_context
branch
from
07dc2c2
to
c988e34
Compare
rouault
reviewed
Aug 18, 2020
snowman2
force-pushed
the
clone_cpp_context
branch
from
c988e34
to
8c6b2dd
Compare
snowman2
force-pushed
the
clone_cpp_context
branch
from
8c6b2dd
to
e51ea3e
Compare
rouault
reviewed
Aug 19, 2020
|
Thanks for reviewing @rouault |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Reasoning:
I made some changes assuming the database path would be copied from the default context. After core dumps, I determined this was not the case. I believe copying the
cpp_contextwill enable this. Thoughts?