Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a +proj=tinshift for triangulation-based transformations #2344

Merged
merged 1 commit into from Sep 30, 2020

Conversation

rouault
Copy link
Member

@rouault rouault commented Sep 2, 2020

Implements RFC-6

@rouault rouault added this to the 7.2.0 milestone Sep 2, 2020
@rouault
Copy link
Member Author

rouault commented Sep 9, 2020

@kbevers @busstoptaktik Want to review this before it is merged ? (no particular emergency, just asking)

Copy link
Member

@kbevers kbevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I only have a couple of minor details to comment on. One is inlined the other below.

What's the difference between data/triangulation.schema.json and schemas/triangulation.schema.json? They seem to be the same thing, do we really need both of them?

docs/source/operations/transformations/tinshift.rst Outdated Show resolved Hide resolved
@rouault
Copy link
Member Author

rouault commented Sep 30, 2020

What's the difference between data/triangulation.schema.json and schemas/triangulation.schema.json? They seem to be the same thing, do we really need both of them?

They're the same. That's similar to projjson schema. The one in data/ is to be installed with make install in /usr/share/proj . The one under schemas/ is for the website. But I've modified docs/Makefile to copy the one from data/ to the deployed website /schemas

@kbevers
Copy link
Member

kbevers commented Sep 30, 2020

But I've modified docs/Makefile to copy the one from data/ to the deployed website /schemas

Thanks. I prefer to only have a single copy when possible.

I'm happy to see this merged once the tests have run again. Good job on this implementation of RFC6! I'm sure our Finish friends will be very happy about this.

@rouault rouault merged commit 48c3a9a into OSGeo:master Sep 30, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants