Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGO48 (EPSG:4273) to ETRS89 (EPSG:4258) triangulation-based transformation #2554

Merged
merged 11 commits into from Mar 10, 2021

Conversation

himsve
Copy link
Contributor

@himsve himsve commented Mar 4, 2021

NGO48 (EPSG:4273) to ETRS89 (EPSG:4258) triangulation-based transformation.

The transformation is based on the TIN-json file 'no_kv_ETRS89NO_NGO48_TIN.json'. The transformation in mentioned TIN-file has the direction EPSG:4258>EPSG:4273.

The transformation EPSG:4273>EPSG:4258 is already defined as EPSG:1653 at https://epsg.io/1653 as a Position Vector transformation (EPSG:9606). The triangulation-based NGO48>ETRS89 transformation is not yet registered with new EPSG code due to that triangulation-based transformation is not registered as method at epsg.io.

Preliminary the EPSG:4273>EPSG:4258 triangulation-based transformation is implemented as encapsulated proj string in other_tranformation.

This pull request is related to #OSGeo/PROJ-data#60

  • Tests added. GIE test EPSG:4258>EPSG:27393.
  • Added clear title that can be used to generate release notes
  • Resource file added to https://github.com/OSGeo/PROJ-data
  • EPSG code registration

data/Makefile.am Outdated Show resolved Hide resolved
data/sql/other_transformation_custom.sql Outdated Show resolved Hide resolved
data/sql/other_transformation_custom.sql Outdated Show resolved Hide resolved
test/gie/tinshift.gie Outdated Show resolved Hide resolved
himsve and others added 5 commits March 4, 2021 12:07
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
tinshift_simplified_etrs89_ngo48.json removed in Makefile
@rouault
Copy link
Member

rouault commented Mar 9, 2021

@himsve Do you want to get this merged as it before EPSG comes with a code for the tinshift method ?

@himsve
Copy link
Contributor Author

himsve commented Mar 10, 2021

Yes, please merged it. As I mentioned, this is just a temporary solution until EPSG handles TIN transformations. But it's works well. 👍

@rouault rouault added this to the 8.1.0 milestone Mar 10, 2021
@rouault rouault merged commit ffc6e87 into OSGeo:master Mar 10, 2021
rouault added a commit to rouault/PROJ that referenced this pull request Mar 23, 2021
…), and NGO48 to ETRS89 TIN transfrm (OSGeo#2554)

* Correction grid NKG:ETRF14 to EPSG:7922

* Added NKG:ITRF_TO_NO GIE test

* Correction grid no_kv_NKGETRF14_EPSG7922_2000 added to grid_alternatives.sql

* proj_method 'velocity_grid' added in check_grid_alternatives_proj_method. NKG velocity grid added to grid_alternatives.sql

* also include follow-up fix to master OSGeo#2548: e10a849

* Add NGO48 (EPSG:4273) to ETRS89 (EPSG:4258) triangulation-based transformation (OSGeo#2554)

Co-authored-by: Even Rouault <even.rouault@spatialys.com>
@himsve himsve deleted the ngo48_typo branch May 14, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants