Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal nlohmann/json to 3.9.1, and add a CMake option to be able to use external nlohmann/json #2686

Merged
merged 2 commits into from Apr 30, 2021

Conversation

rouault
Copy link
Member

@rouault rouault commented Apr 23, 2021

Using external nlohmann/json can potentially help reducing binary size for people doing static builds with other components that already use it. And more in line with the general philosophy of packaging.

@rouault rouault requested a review from mwtoews April 23, 2021 12:34
@mwtoews
Copy link
Member

mwtoews commented Apr 26, 2021

Review in progress, and may take a few days ... my spare time is limited.

I'll probably add a commit here when ready, as I'm seeing potential conflicts from Ubuntu bionic with nlohmann-json-dev, which is too old (2.1.1) and doesn't contain NLOHMANN_JSON_VERSION_* definitions.

@mwtoews
Copy link
Member

mwtoews commented Apr 29, 2021

See some suggested edits at rouault#7

rouault and others added 2 commits April 30, 2021 13:27
…g allowing to choose which nlohmann/json to use

Co-authored-by: Mike Taves <mwtoews@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants