Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_network.cpp: try to fix 'Please include winsock2.h before windows.h' warning with msys #2692

Merged
merged 1 commit into from Apr 23, 2021

Conversation

rouault
Copy link
Member

@rouault rouault commented Apr 23, 2021

In file included from D:/a/_temp/msys/msys64/mingw64/include/curl/system.h:422,
                 from D:/a/_temp/msys/msys64/mingw64/include/curl/curl.h:38,
                 from D:/a/PROJ/PROJ/test/unit/test_network.cpp:48:
D:/a/_temp/msys/msys64/mingw64/x86_64-w64-mingw32/include/winsock2.h:15:2: warning: #warning Please include winsock2.h before windows.h [-Wcpp]
   15 | #warning Please include winsock2.h before windows.h
      |  ^~~~~~~

Seems to be what is described in https://curl.se/mail/lib-2016-12/0047.html

…s.h' warning with msys

```
In file included from D:/a/_temp/msys/msys64/mingw64/include/curl/system.h:422,
                 from D:/a/_temp/msys/msys64/mingw64/include/curl/curl.h:38,
                 from D:/a/PROJ/PROJ/test/unit/test_network.cpp:48:
D:/a/_temp/msys/msys64/mingw64/x86_64-w64-mingw32/include/winsock2.h:15:2: warning: #warning Please include winsock2.h before windows.h [-Wcpp]
   15 | #warning Please include winsock2.h before windows.h
      |  ^~~~~~~
```

Seems to be what is described in https://curl.se/mail/lib-2016-12/0047.html
Copy link
Member

@mwtoews mwtoews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to submit this exact patch last week.

@rouault rouault added this to the 8.1.0 milestone Apr 23, 2021
@rouault rouault merged commit a002a3e into OSGeo:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants