CMake: make BUILD_SHARED_LIBS=ON the default even on Windows #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the reasoning behind this change? |
"why make a special case for Windows" ? And more seriously, static linking is a difficult topic, especially since PROJ has now dependencies to sqlite, curl and geotiff, so it should only be used if people know they really need it. |
|
Thanks @rouault. I have no opinion on the topic just curious as to why it changed, mainly in order to put the right thing in the release notes. |
|
This change makes a lot of sense, very helpful. Good to see. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.