proj_errno_reset: Also reset pj_errno #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, indeed it is unintended behaviour. The global error number within |
kbevers
added a commit
to kbevers/PROJ
that referenced
this pull request
Feb 23, 2018
The error number should not be reset until a new instance of "operation ..." is reached. The ignore-feature initially worked by accident since pj_errno was not being reset when calling proj_errno_reset. This was fixed in OSGeo#808, which subsequently caused ignored tests to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this PostGIS ticket. It has been temporarily solve by setting it manually after an error but I understand it was an unintended behaviour change and it should be handled here.
I've removed the postgis patch and applied this PR and the behaviour remains the same as with 4.9.3.