Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horner: Fail if the order is unreasonably large. #893

Merged
merged 1 commit into from Mar 25, 2018

Conversation

@schwehr
Copy link
Contributor

@schwehr schwehr commented Mar 23, 2018

Overflow in horner_alloc with "2*(int)order"

Found with autofuzz with UndefinedBehaviorSanitizer: signed-integer-overflow (b/73260430)

Overflow in horner_alloc with "2*(int)order"

Found with autofuzz with UndefinedBehaviorSanitizer: signed-integer-overflow
@kbevers kbevers requested review from busstoptaktik and removed request for busstoptaktik Mar 23, 2018
@kbevers
Copy link
Member

@kbevers kbevers commented Mar 25, 2018

I am sure the limit could be lowered by a order of magnitude or two but let's just go with this for now as it fixes the problem. For the record, 15 is the highest degree I have seen in the wild so far.

@kbevers kbevers merged commit 939d78d into OSGeo:master Mar 25, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.008%) to 75.765%
Details
@kbevers kbevers added this to the 5.1.0 milestone Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.