Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gie.c: Initialize test_time other fields. #902

Merged
merged 1 commit into from Mar 26, 2018
Merged

Conversation

schwehr
Copy link
Member

@schwehr schwehr commented Mar 26, 2018

Leaving x, y, z fields unset triggers an MSAN failure.

fwd_prepare pj_fwd.c:40:9
pj_fwd4d pj_fwd.c:260:15
proj_trans proj_4D_api.c:166:20
test_time gie.c:1955:11

src/gie.c Outdated
@@ -1950,6 +1950,9 @@ static int test_time(const char* args, double tol, double t_in, double t_exp) {
if (P == 0)
return 5;

in.xyzt.x = 0.0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about in = proj_coord(0, 0, 0, t_in); for a simpler initialization?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Done.

Leaving x, y, z fields unset triggers an MSAN failure.

fwd_prepare pj_fwd.c:40:9
pj_fwd4d    pj_fwd.c:260:15
proj_trans  proj_4D_api.c:166:20
test_time   gie.c:1955:11
@kbevers kbevers added this to the 5.1.0 milestone Mar 26, 2018
@kbevers kbevers merged commit a1d9245 into OSGeo:master Mar 26, 2018
@schwehr schwehr deleted the gie-time branch March 26, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants