Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and bugfix for the Orthographic projection #912

Merged
merged 2 commits into from Mar 30, 2018

Conversation

@kbevers
Copy link
Member

@kbevers kbevers commented Mar 30, 2018

Test cases from Snyder added to gie test suite. While doing this I discovered that erroneous points where returned as (0,0) instead of the expected (HUGE_VAL, HUGE_VAL). This is also fixed in this PR. A error message is also added to the trace log when such transient errors occur.

@kbevers kbevers added this to the 5.1.0 milestone Mar 30, 2018
@kbevers kbevers force-pushed the kbevers:ortho-tests branch 4 times, most recently from c42e10d to 6b3616c Mar 30, 2018
@kbevers
Copy link
Member Author

@kbevers kbevers commented Mar 30, 2018

98.67% test coverage. I guess that's as good as it gets.

@busstoptaktik I need an option in gie that lets me hit those return pj_default_destructor(P, ENOMEM); lines :-)

@kbevers kbevers force-pushed the kbevers:ortho-tests branch from 6b3616c to 73dc34b Mar 30, 2018
@kbevers kbevers merged commit 73996d0 into OSGeo:master Mar 30, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 75.981%
Details
@kbevers kbevers deleted the kbevers:ortho-tests branch Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.