Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always ignore out-commented lines in cct #933

Merged
merged 1 commit into from Apr 13, 2018

Conversation

@kbevers
Copy link
Member

@kbevers kbevers commented Apr 13, 2018

Previous to this commit cct would return the following

$ cct -c 2,3,4 -t 0 -I +proj=cart +ellps=GRS80
BLAH    3579685.56545   508396.50343  5236837.50646
  8.0832413787   55.5578176654       99.9833        0.0000
#BLAH    3579685.56545   508396.50343  5236837.50646
  8.0832413787   55.5578176654       99.9833        0.0000

where the second input should not be parsed as a valid coordinate.
With this commit that no longer happens and the input is returned
verbatim back to the user.

Closes #932

Previous to this commit cct would return the following

$ cct -c 2,3,4 -t 0 -I +proj=cart +ellps=GRS80
BLAH    3579685.56545   508396.50343  5236837.50646
  8.0832413787   55.5578176654       99.9833        0.0000
  8.0832413787   55.5578176654       99.9833        0.0000

where the second input should not be parsed as a valid coordinate.
With this commit that no longer happens and the input is returned
verbatim back to the user.

Closes #932
@kbevers kbevers added this to the 5.1.0 milestone Apr 13, 2018
@kbevers kbevers merged commit a023410 into OSGeo:master Apr 13, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 77.504%
Details
@kbevers kbevers deleted the kbevers:cct-respect-comments branch Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.