Permalink
Browse files

Rename .gitattributes as.gitattributes.disabled as it causes a lot of…

… end-of-line changes on clone on Linux
  • Loading branch information...
rouault committed Oct 9, 2018
1 parent 73e09dd commit cdbba83cc3eea4ef48b3205865432f40fe0bbc52
Showing with 0 additions and 0 deletions.
  1. 0 .gitattributes → .gitattributes.disabled
File renamed without changes.

4 comments on commit cdbba83

@rouault

This comment has been minimized.

Show comment
Hide comment
@rouault

rouault Oct 9, 2018

Member

@mloskot I had to do this because it caused issues on Linux. When doing a completely fresh "git clone", there were 51 files that were indicated as modified ! Despite trying with "git config --global core.autocrlf false"

Member

rouault replied Oct 9, 2018

@mloskot I had to do this because it caused issues on Linux. When doing a completely fresh "git clone", there were 51 files that were indicated as modified ! Despite trying with "git config --global core.autocrlf false"

@mloskot

This comment has been minimized.

Show comment
Hide comment
@mloskot

mloskot Oct 10, 2018

Member

@rouault Hmm, it's puzzling. I was fresh cloning many times while refining the .gitattributes and did not notice any issues, but perhaps I missed some combination of configs. I will see what is going on, test against my for thoroughly and submit PR with corrections. Thanks for catching this and sorry for trouble again.

Member

mloskot replied Oct 10, 2018

@rouault Hmm, it's puzzling. I was fresh cloning many times while refining the .gitattributes and did not notice any issues, but perhaps I missed some combination of configs. I will see what is going on, test against my for thoroughly and submit PR with corrections. Thanks for catching this and sorry for trouble again.

@mloskot

This comment has been minimized.

Show comment
Hide comment
@mloskot

mloskot Oct 10, 2018

Member

@rouault I've disabled the * text=auto as default behaviour and I think it's getting close to working state:

image

On Linux, just two files get modified:

modified:   gdal/submake.bat
modified:   gdal/swig/java/gnm/makefile.vc

I think they may require EOL fix to CRLF.

Member

mloskot replied Oct 10, 2018

@rouault I've disabled the * text=auto as default behaviour and I think it's getting close to working state:

image

On Linux, just two files get modified:

modified:   gdal/submake.bat
modified:   gdal/swig/java/gnm/makefile.vc

I think they may require EOL fix to CRLF.

@mloskot

This comment has been minimized.

Show comment
Hide comment
@mloskot

mloskot Oct 10, 2018

Member

I proposed refinement of the .gitattributes in #998

Member

mloskot replied Oct 10, 2018

I proposed refinement of the .gitattributes in #998

Please sign in to comment.